Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Update docs on testing against non-released library version #4191

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

y9v
Copy link
Member

@y9v y9v commented Feb 25, 2025

Motivation

I found the existing documentation confusing. It looks like I need to perform both actions - add ruby-load-from-bundle-add and clone the library repo to binaries folder.

Changes

The documentation on how to run tests against non-released Ruby tracer library locally are updated.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v self-assigned this Feb 25, 2025
@y9v y9v requested a review from a team as a code owner February 25, 2025 15:51
@y9v y9v merged commit 50ad640 into main Feb 26, 2025
70 checks passed
@y9v y9v deleted the ruby-update-instructions-on-using-non-released-library branch February 26, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants