Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_root_span helper #4206

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Add get_root_span helper #4206

merged 1 commit into from
Feb 27, 2025

Conversation

smola
Copy link
Member

@smola smola commented Feb 27, 2025

Motivation

Most of the time, when get check for the root span for a request, we're assuming the following:

  • There is a request.
  • There is one, and only one, root span.

So created a get_root_span to be used for the common case, properly asserting these preconditions, and avoiding redundant boilerplate with iterators. Special cases can still use the more general get_root_spans and get_spans.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola force-pushed the smola/get-the-root-span branch from 80edda3 to 50f96c8 Compare February 27, 2025 10:30
@smola smola force-pushed the smola/get-the-root-span branch from 50f96c8 to 593adf4 Compare February 27, 2025 11:00
@smola smola changed the title Add get_the_root_span helper Add get_root_span helper Feb 27, 2025
@smola smola marked this pull request as ready for review February 27, 2025 11:50
@smola smola requested review from a team as code owners February 27, 2025 11:50
@smola smola enabled auto-merge (squash) February 27, 2025 14:00
@smola smola merged commit 773c9bd into main Feb 27, 2025
336 checks passed
@smola smola deleted the smola/get-the-root-span branch February 27, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants