Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] API Security sampling endpoints #4209

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

smola
Copy link
Member

@smola smola commented Feb 27, 2025

Motivation

Addding missing weblog endpoints for API Security sampling endpoints.

I'll enable tests as needed in separate PR at #4195. For now, I want to get the endpoints merged, to avoid the other PRs for the manifest automatically triggering all scenarios in CI on every push.

APPSEC-54874

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola added the java Pull requests that update Java code label Feb 27, 2025
@smola smola marked this pull request as ready for review February 27, 2025 13:02
@smola smola requested review from a team as code owners February 27, 2025 13:02
@smola smola enabled auto-merge (squash) February 27, 2025 14:01
@smola smola merged commit 4b8e1ed into main Feb 27, 2025
55 checks passed
@smola smola deleted the smola/api-sec-sampling-weblogs branch February 27, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants