Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Enable Xpassed tests in Test_Blocking_response_status #4215

Conversation

jandro996
Copy link
Member

@jandro996 jandro996 commented Feb 28, 2025

Motivation

Fix Xpassed tests APPSEC-54879

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@jandro996 jandro996 marked this pull request as ready for review February 28, 2025 11:02
@jandro996 jandro996 requested review from a team as code owners February 28, 2025 11:02
@jandro996 jandro996 changed the title [JAVA] Enable Xpassed tests in Test_Blocking_response_status [java] Enable Xpassed tests in Test_Blocking_response_status Feb 28, 2025
@jandro996 jandro996 merged commit 3276393 into main Feb 28, 2025
96 checks passed
@jandro996 jandro996 deleted the alejandro.gonzalez/Test_Blocking_response_status-test_not_found-Xpass branch February 28, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants