-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone billing features, scenarios and tests reorg #4216
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -808,6 +808,7 @@ tests/: | |
'*': v1.45.0 | ||
spring-boot-3-native: missing_feature (GraalVM. Tracing support only) | ||
# SQLi was introduced in v1.38.0 (with RASP disabled by default, but was flaky) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's from the linter... |
||
test_sqli.py: | ||
Test_Sqli_BodyJson: | ||
'*': v1.39.0 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -767,8 +767,8 @@ def test_client_computed_stats_header_is_not_present(self): | |
|
||
|
||
@rfc("https://docs.google.com/document/d/12NBx-nD-IoQEMiCRnJXneq4Be7cbtSc6pJLOFUWTpNE/edit") | ||
@features.appsec_standalone | ||
@scenarios.appsec_standalone | ||
@features.appsec_standalone_experimental | ||
@scenarios.appsec_standalone_experimental | ||
@irrelevant(context.library > "[email protected]", reason="V2 is implemented for newer versions") | ||
class Test_AppSecStandalone_UpstreamPropagation(AppSecStandalone_UpstreamPropagation_Base): | ||
"""APPSEC correctly propagates AppSec events in distributing tracing with DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED=true.""" | ||
|
@@ -781,8 +781,8 @@ def propagated_tag_value(self): | |
|
||
|
||
@rfc("https://docs.google.com/document/d/12NBx-nD-IoQEMiCRnJXneq4Be7cbtSc6pJLOFUWTpNE/edit") | ||
@features.appsec_standalone_v2 | ||
@scenarios.appsec_standalone_v2 | ||
@features.appsec_standalone | ||
@scenarios.appsec_standalone | ||
class Test_AppSecStandalone_UpstreamPropagation_V2(AppSecStandalone_UpstreamPropagation_Base): | ||
"""APPSEC correctly propagates AppSec events in distributing tracing with DD_APM_TRACING_ENABLED=false.""" | ||
|
||
|
@@ -794,8 +794,8 @@ def propagated_tag_value(self): | |
|
||
|
||
@rfc("https://docs.google.com/document/d/12NBx-nD-IoQEMiCRnJXneq4Be7cbtSc6pJLOFUWTpNE/edit") | ||
@features.iast_standalone | ||
@scenarios.iast_standalone | ||
@features.iast_standalone_experimental | ||
@scenarios.iast_standalone_experimental | ||
@irrelevant(context.library > "[email protected]", reason="V2 is implemented for newer versions") | ||
class Test_IastStandalone_UpstreamPropagation(IastStandalone_UpstreamPropagation_Base): | ||
"""IAST correctly propagates AppSec events in distributing tracing with DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED=true.""" | ||
|
@@ -808,8 +808,8 @@ def propagated_tag_value(self): | |
|
||
|
||
@rfc("https://docs.google.com/document/d/12NBx-nD-IoQEMiCRnJXneq4Be7cbtSc6pJLOFUWTpNE/edit") | ||
@features.iast_standalone_v2 | ||
@scenarios.iast_standalone_v2 | ||
@features.iast_standalone | ||
@scenarios.iast_standalone | ||
class Test_IastStandalone_UpstreamPropagation_V2(IastStandalone_UpstreamPropagation_Base): | ||
"""IAST correctly propagates AppSec events in distributing tracing with DD_APM_TRACING_ENABLED=false.""" | ||
|
||
|
@@ -821,8 +821,8 @@ def propagated_tag_value(self): | |
|
||
|
||
@rfc("https://docs.google.com/document/d/12NBx-nD-IoQEMiCRnJXneq4Be7cbtSc6pJLOFUWTpNE/edit") | ||
@features.sca_standalone | ||
@scenarios.sca_standalone | ||
@features.sca_standalone_experimental | ||
@scenarios.sca_standalone_experimental | ||
@irrelevant(context.library > "[email protected]", reason="V2 is implemented for newer versions") | ||
class Test_SCAStandalone_Telemetry(SCAStandalone_Telemetry_Base): | ||
"""Tracer correctly propagates SCA telemetry in distributing tracing with DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED=true.""" | ||
|
@@ -835,8 +835,8 @@ def propagated_tag_value(self): | |
|
||
|
||
@rfc("https://docs.google.com/document/d/12NBx-nD-IoQEMiCRnJXneq4Be7cbtSc6pJLOFUWTpNE/edit") | ||
@features.sca_standalone_v2 | ||
@scenarios.sca_standalone_v2 | ||
@features.sca_standalone | ||
@scenarios.sca_standalone | ||
class Test_SCAStandalone_Telemetry_V2(SCAStandalone_Telemetry_Base): | ||
"""Tracer correctly propagates SCA telemetry in distributing tracing with DD_APM_TRACING_ENABLED=false.""" | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -337,18 +337,18 @@ class _Scenarios: | |
"APPSEC_STANDALONE", | ||
weblog_env={ | ||
"DD_APPSEC_ENABLED": "true", | ||
"DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED": "true", | ||
"DD_APM_TRACING_ENABLED": "false", | ||
"DD_IAST_ENABLED": "false", | ||
}, | ||
doc="Appsec standalone mode (APM opt out)", | ||
scenario_groups=[ScenarioGroup.APPSEC], | ||
) | ||
|
||
appsec_standalone_v2 = EndToEndScenario( | ||
"APPSEC_STANDALONE_V2", | ||
appsec_standalone_experimental = EndToEndScenario( | ||
"APPSEC_STANDALONE_EXPERIMENTAL", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renaming scenario is dangerous, you need to crawl all CI to verify that they do not refer to it, and update them if needed. Two good enough solution for that issue :
|
||
weblog_env={ | ||
"DD_APPSEC_ENABLED": "true", | ||
"DD_APM_TRACING_ENABLED": "false", | ||
"DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED": "true", | ||
"DD_IAST_ENABLED": "false", | ||
}, | ||
doc="Appsec standalone mode (APM opt out) V2", | ||
|
@@ -359,7 +359,7 @@ class _Scenarios: | |
"IAST_STANDALONE", | ||
weblog_env={ | ||
"DD_APPSEC_ENABLED": "false", | ||
"DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED": "true", | ||
"DD_APM_TRACING_ENABLED": "false", | ||
"DD_IAST_ENABLED": "true", | ||
"DD_IAST_DETECTION_MODE": "FULL", | ||
"DD_IAST_DEDUPLICATION_ENABLED": "false", | ||
|
@@ -369,11 +369,11 @@ class _Scenarios: | |
scenario_groups=[ScenarioGroup.APPSEC], | ||
) | ||
|
||
iast_standalone_v2 = EndToEndScenario( | ||
"IAST_STANDALONE_V2", | ||
iast_standalone_experimental = EndToEndScenario( | ||
"IAST_STANDALONE_EXPERIMENTAL", | ||
weblog_env={ | ||
"DD_APPSEC_ENABLED": "false", | ||
"DD_APM_TRACING_ENABLED": "false", | ||
"DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED": "true", | ||
"DD_IAST_ENABLED": "true", | ||
"DD_IAST_DETECTION_MODE": "FULL", | ||
"DD_IAST_DEDUPLICATION_ENABLED": "false", | ||
|
@@ -388,20 +388,20 @@ class _Scenarios: | |
weblog_env={ | ||
"DD_APPSEC_ENABLED": "false", | ||
"DD_APPSEC_SCA_ENABLED": "true", | ||
"DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED": "true", | ||
"DD_APM_TRACING_ENABLED": "false", | ||
"DD_IAST_ENABLED": "false", | ||
"DD_TELEMETRY_DEPENDENCY_RESOLUTION_PERIOD_MILLIS": "1", | ||
}, | ||
doc="SCA standalone mode (APM opt out)", | ||
scenario_groups=[ScenarioGroup.APPSEC], | ||
) | ||
|
||
sca_standalone_v2 = EndToEndScenario( | ||
"SCA_STANDALONE_V2", | ||
sca_standalone_experimental = EndToEndScenario( | ||
"SCA_STANDALONE_EXPERIMENTAL", | ||
weblog_env={ | ||
"DD_APPSEC_ENABLED": "false", | ||
"DD_APPSEC_SCA_ENABLED": "true", | ||
"DD_APM_TRACING_ENABLED": "false", | ||
"DD_EXPERIMENTAL_APPSEC_STANDALONE_ENABLED": "true", | ||
"DD_IAST_ENABLED": "false", | ||
"DD_TELEMETRY_DEPENDENCY_RESOLUTION_PERIOD_MILLIS": "1", | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one also (
./format.sh
)