Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix /shell_execution endpoint in Spring Boot when args is an array #4217

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

smola
Copy link
Member

@smola smola commented Feb 28, 2025

Motivation

This endpoint for /shell_execution in Spring Boot is sometimes throwing exceptions because args can be a String or an array, and we supported only String. No test failing because these are skipped for other reasons. Fixed the endpoint, so we should have a proper XPASS when the time comes.

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@smola smola marked this pull request as ready for review February 28, 2025 11:25
@smola smola requested review from a team as code owners February 28, 2025 11:25
@smola smola enabled auto-merge (squash) February 28, 2025 11:27
@smola smola merged commit 359d444 into main Feb 28, 2025
55 checks passed
@smola smola deleted the smola/shell-execution-test branch February 28, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants