Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodejs] Mark as irrelevant standalone v1 tests #4225

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Feb 28, 2025

Motivation

Standalone v1 tests are not longer valid due to a newer way to disable apm tracing

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@iunanua iunanua force-pushed the igor/nodejs-standalone-v1-disable branch from a6e5c34 to 4ce80e5 Compare February 28, 2025 16:05
@iunanua iunanua force-pushed the igor/nodejs-standalone-v1-disable branch from 4ce80e5 to 2aa82a7 Compare February 28, 2025 16:12
@iunanua iunanua marked this pull request as ready for review February 28, 2025 16:15
@iunanua iunanua requested a review from a team as a code owner February 28, 2025 16:15
@iunanua iunanua changed the title [nodejs] Mark irrlelevant standalone v1 tests [nodejs] Mark as irrelevant standalone v1 tests Feb 28, 2025
@iunanua iunanua merged commit 9f3fd20 into main Feb 28, 2025
28 checks passed
@iunanua iunanua deleted the igor/nodejs-standalone-v1-disable branch February 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants