Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions.md with instructions for dd-trace-java and dd-trace-go #4228

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mtoffl01
Copy link
Contributor

Motivation

Make it clear how to reference the main/master branch for Go and Java tracers

Changes

Update versions.md with instructions for dd-trace-java and dd-trace-go

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mtoffl01 mtoffl01 requested a review from a team as a code owner February 28, 2025 17:53
@@ -19,11 +19,15 @@ Simply use `1.2.3`
### Activate a test for a feature just merged on a `main` branch

* obviously, do not use `1.2.3`
* less obvious, do not use `1.2.4` ! your test won't be activated. If if you didn't implemented correctly your feature, or if a later PR break your implementation, you won't see anything before the release 😨
* less obvious, do not use `1.2.4` ! your test won't be activated. If you didn't your feature implemented correctly, or if a later PR has broken your implementation, you won't see anything before the release 😨
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* less obvious, do not use `1.2.4` ! your test won't be activated. If you didn't your feature implemented correctly, or if a later PR has broken your implementation, you won't see anything before the release 😨
* less obvious, do not use `1.2.4` ! your test won't be activated. If you didn't implement your feature correctly, or if a later PR has broken your implementation, you won't see anything before the release 😨

Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small grammar fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants