-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datadog_logs_archives] Handle encryption field for S3 destinations for Logs Archives #2740
Open
michelledeng30
wants to merge
16
commits into
master
Choose a base branch
from
michelle.deng/handle-encryption-in-logs-API
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0b3fc25
Add encryption to logs archives
michelledeng30 1d97952
Encryption settings are optional
michelledeng30 a9766fa
Encryption_type is not required
michelledeng30 a863d0e
Testing s3 logs archives tests
michelledeng30 c94b4ee
Re-run test cassettes
michelledeng30 c194f0f
Merge branch 'master' into michelle.deng/handle-encryption-in-logs-API
michelledeng30 d0da016
Update go client
michelledeng30 170795c
Update docs
michelledeng30 dcd3296
successfully run s3 update test and make replay-only
michelledeng30 55f644e
rerun basic s3 archive test
michelledeng30 9509b26
re-run logs archives order datasource test
michelledeng30 cf35c9a
formatting/spacing
michelledeng30 a2db65a
terraform format
michelledeng30 b2a921e
Create optional encryption block
michelledeng30 a6f01b9
Update docs
michelledeng30 a3fe5bb
Re-run tests
michelledeng30 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume from reading the code that if the user sets SSE_KMS as the encryption type but doesn't provide an encryption key we do not want to handle this error here and just pass the values along is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's right, technically setting SSE_KMS with no encryption key is also a valid method (just not done very commonly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I didn't know that. Thanks for explaining!