[datadog_logs_custom_pipeline] Add tags and description to logs pipelines #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultkrebs
approved these changes
Jan 29, 2025
janine-c
approved these changes
Jan 29, 2025
EdwinSri
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Could you please add a PR description? 😄 I am not familiar with this part of the code so don't really understand what change is being made, why we are making this change and why my team needs to review it.
EDIT: edited out the part about linking the jira ticket since apparently github is smart enough to pick it up from the PR title
LorisFriedel
approved these changes
Jan 30, 2025
EdwinSri
approved these changes
Jan 30, 2025
joboccara
changed the title
skarimo
reviewed
Jan 30, 2025
| @@ -63,6 +63,21 @@ func dataSourceDatadogLogsPipelines() *schema.Resource { | |||
| Type: schema.TypeBool, | |||
| Computed: true, | |||
| }, | |||
| "tags": { | |||
| Description: "Tags of the pipeline", | |||
| Type: schema.TypeList, | |||
There was a problem hiding this comment.
Suggested change
| Type: schema.TypeList, | |
| Type: schema.TypeSet, |
| "is_enabled": {Type: schema.TypeBool, Optional: true}, | ||
| "name": {Type: schema.TypeString, Required: true}, | ||
| "is_enabled": {Type: schema.TypeBool, Optional: true}, | ||
| "tags": {Type: schema.TypeList, Optional: true, Elem: &schema.Schema{Type: schema.TypeString}}, |
There was a problem hiding this comment.
Suggested change
| "tags": {Type: schema.TypeList, Optional: true, Elem: &schema.Schema{Type: schema.TypeString}}, | |
| "tags": {Type: schema.TypeSet, Optional: true, Elem: &schema.Schema{Type: schema.TypeString}}, |
There was a problem hiding this comment.
@skarimo if we use a set isn't it a risk of changing the order of the tags?
The set has the advantage of unicity but the pipelines API already does dedup if necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the tags and description for pipelines to the Datadog Terraform provider.
The provider interprets the Terraform files and uses the Go SDK to invoke the Datadog public API to change the state of the logs pipelines and make them match the state expressed in the Terraform files. This PR makes it read and writes the tags and description of logs pipelines from the public API.
LOGSC-2078