Skip to content

Enable choosing file names for dfd and dd #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Kr0nox
Copy link
Contributor

@Kr0nox Kr0nox commented Jul 18, 2025

Allows the user to input a file name for the dfd and dd upon saving. The default in the input box is the file name as it was previously. When an empty string is given or the action is canceled, it also fills in the file name

Closes DataFlowAnalysis/DataFlowAnalysis#286

Copy link
Member

@Entenwilli Entenwilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not work in itself, because the received Dataflow Diagram contains references to the file name.

Therefore, the backend needs to receive the file name, as ugly as it may seem (and is!), then send the file with the correct file names

@Entenwilli
Copy link
Member

Tagging @01Parzival10 as some backend changes are required

@01Parzival10
Copy link
Contributor

I'll take a look at it tomorrow. I currently don't have access to a PC/Laptop

Copy link
Contributor

@01Parzival10 01Parzival10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work this way. The name has to be set before the diagram is sent to the backend. Meaning the dialog has to happen before line 64

@Kr0nox
Copy link
Contributor Author

Kr0nox commented Jul 22, 2025

Is it possible for the backend to also end back the file name? Otherwise, it would lead to some not ideal state management in the web viewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name of DD and DFD download
3 participants