Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add .gitignore #3119

Closed
wants to merge 1 commit into from
Closed

Conversation

rsekman
Copy link
Contributor

@rsekman rsekman commented Sep 1, 2024

running the test suite creates the empty file Tests/PresetManagerData/dspconfig, which should be ignored

running the test suite creates the empty file Tests/PresetManagerData/dspconfig, which should be ignored
@Oleksiy-Yakovenko
Copy link
Member

Oleksiy-Yakovenko commented Sep 3, 2024

IMO this fixes a symptom instead of the root cause.
The tests should not be writing there.
I probably just haven't noticed this, since I almost always run tests via Xcode where this problem isn't present.
The correct solution is to copy test assets to some temporary directory, and then execute tests there.
Even better is to provide a mechanism to prevent the code from writing this config file during tests.

@Oleksiy-Yakovenko
Copy link
Member

I applied another fix, merged to master. Please let me know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants