Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lit, Hangable Lanterns #32

Merged
merged 4 commits into from
Apr 23, 2023
Merged

Lit, Hangable Lanterns #32

merged 4 commits into from
Apr 23, 2023

Conversation

falkreon
Copy link
Member

Makes a number of changes to post lanterns:

  • Fixes their luminosity at 15 regardless of what the frame material is
  • Adds the 'hanging' property which locates the lantern at the top of the cube it's in
  • Updates the blockstate template and models to accommodate the new property
  • Updates the post lantern BlockType so it generates the new hanging models
  • Removes eight hidden faces from the models
  • Changes the voxelshape to fit the model exactly
  • New utility class that can ask a VoxelShape if it has a particular 1/16th voxel set

Any lanterns saved in a map prior to this update will unfortunately default to "hanging=true". QSL's datafixers are offline at the moment so I can't make an auto-fix. Any existing lanterns can be fixed by causing a block update, such as placing and breaking a torch next to it.

Copy link
Collaborator

@woodiertexas woodiertexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside from a few nitpicky things.

@maximumpower55 maximumpower55 merged commit 21ea65a into DebuggyTeam:1.19 Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants