Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mangrove tables (1.1.2), make azalea and jacaranda mineable. #33

Merged
merged 7 commits into from
May 28, 2023
Merged

Add mangrove tables (1.1.2), make azalea and jacaranda mineable. #33

merged 7 commits into from
May 28, 2023

Conversation

sisby-folk
Copy link

@sisby-folk sisby-folk commented May 23, 2023

Changes:

  • 1.1.2 changes - mangrove block loot tables and mineability
    • Fix duplicate listings for mangrove in mineable tags
  • Adds jacaranda and azalea blocks to the mineable/axe tag
  • Adds jacaranda and azalea post caps / lanterns (uses amethyst lantern textures/recipes)

@sisby-folk
Copy link
Author

sisby-folk commented May 23, 2023

Tested:

javaw_cpOxrFjMm4.mp4

@woodiertexas woodiertexas requested a review from Ampflower May 23, 2023 04:33
Won't have the mob cancelling effect, but there's no tag for that sadly.
@sisby-folk
Copy link
Author

sisby-folk commented May 23, 2023

& with using amethyst instead of soul (oops!)

Amethyst post lamps won't have the cool 32-block spawn cancel effect, but maybe in 2.0 aurora's deco compat we can ask for a tag ^^

javaw_hG49wnTZ5r.mp4

Copy link
Member

@falkreon falkreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one small nitpick, but looks really good

@sisby-folk sisby-folk requested a review from falkreon May 24, 2023 08:02
Copy link
Member

@falkreon falkreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Ampflower Ampflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mainly just styling issues that I can see; tho the files evidently didn't respect .editorconfig.

Otherwise looks good to me.

Comment on lines 70 to 76
"architecture_extensions:warped_post_lantern",
"architecture_extensions:mangrove_post_cap",
"architecture_extensions:mangrove_post_lantern",
"architecture_extensions:jacaranda_post_cap",
"architecture_extensions:jacaranda_post_lantern",
"architecture_extensions:azalea_post_cap",
"architecture_extensions:azalea_post_lantern"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indentation moment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted in a4af478

Comment on lines 161 to 167
"architecture_extensions:warped_post_lantern",
"architecture_extensions:mangrove_post_cap",
"architecture_extensions:mangrove_post_lantern",
"architecture_extensions:jacaranda_post_cap",
"architecture_extensions:jacaranda_post_lantern",
"architecture_extensions:azalea_post_cap",
"architecture_extensions:azalea_post_lantern"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted in a4af478

@woodiertexas woodiertexas merged commit ca51bda into DebuggyTeam:1.19_pre_rewrite May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants