Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server translation option, clean up BlockType and block creation #44

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

falkreon
Copy link
Member

@falkreon falkreon commented Aug 4, 2023

This is a complicated diff, but I think it's worth it.

  • Extends the new TypedGrouped interface to all ArchEx blocks. All blocks now know the full TypedGroupedBlock that they were initialized based on.
    • Creates a helper method in TypedGrouped to get a good-enoguh-for-blanketcon serverside translation Text based on the TypedGroupedBlock information.
    • Overrides getName() in all ArchEx blocks to return this serverside name
  • Add (block, settings, typedgroupedblock) constructors to all ArchEx blocks
    • Switch all BlockType creators from lambdas to constructor references

This should smooth over some rough edges for BlanketCon and make some of the code much easier to read.

Copy link
Collaborator

@woodiertexas woodiertexas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@maximumpower55 maximumpower55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximumpower55 maximumpower55 merged commit 0967247 into 1.20 Aug 7, 2023
@falkreon falkreon deleted the falk_work branch August 7, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants