Add smoke-build CI workflow #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bravo 🎉 |
An error occurred while trying to automatically change base from
ci-build
to
master
October 7, 2024 15:38
IanVS
force-pushed
the
ci-actually-build
branch
from
0046f68 to
c1f2374
Compare
jasikpark
previously approved these changes
Oct 7, 2024
IanVS
force-pushed
the
ci-actually-build
branch
from
c1f2374 to
7b507b4
Compare
nbrownus
reviewed
Oct 10, 2024
ios/fastlane/Fastfile
Outdated
| @@ -18,6 +18,50 @@ default_platform(:ios) | |||
| platform :ios do | |||
| desc "Push a new beta build to TestFlight" | |||
|
|
|||
| lane :checkBuild do | |||
There was a problem hiding this comment.
Do we need the signing credentials available? If yes, if we switch this to debug can we avoid it?
IanVS
force-pushed
the
ci-actually-build
branch
2 times, most recently
from
cf6f6e9 to
1c32d11
Compare
IanVS
commented
Oct 15, 2024
| @@ -9,7 +9,7 @@ clean: | |||
|
|
|||
| mobileNebula.aar: *.go go.sum | |||
| go get -d golang.org/x/mobile/cmd/gomobile | |||
| gomobile bind -trimpath -v --target=android -androidapi 26 | |||
| gomobile bind -trimpath -v --target=android -androidapi=26 | |||
There was a problem hiding this comment.
this is dumb but might as well keep it consistent with --target
IanVS
force-pushed
the
ci-actually-build
branch
from
1c32d11 to
71e6734
Compare
|
I wish we had this prior to the last PR being merged, which upgraded nebula but caused the build to break. Working on fixing it now, but would love a review on this PR in the meantime. |
nbrownus
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workflow into PRs to build the iOS and Android apps, just to verify that they aren't completely broken / unable to build. They're debug builds, so it won't completely mirror the release build, but that allows us to avoid getting signing keys in the workflow.