Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polished for FCMRebooted Demo #269

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

Ztaclie
Copy link
Contributor

@Ztaclie Ztaclie commented Nov 27, 2024

Summary

This pull request refines the README for the FCM Rebooted Demo project, making it more user-friendly and professional.

Key Changes

  • Structured content with clear and consistent headings.
  • Added code blocks for configuration paths, commands, and JSON examples.
  • Streamlined language for readability and simplicity.
  • Highlighted key warnings and notes for better visibility.
  • Enhanced navigation with cross-referenced links.

Benefits

  • Easier for developers to follow configuration and setup instructions.
  • Improved clarity and usability for the README.
  • Better alignment with professional documentation standards.

Please review and suggest any additional improvements!

@DelphiWorlds DelphiWorlds self-assigned this Nov 27, 2024
@DelphiWorlds
Copy link
Owner

On line 8, it should read: "multiple lines of text", as per the original
On line 11, it should read: "You no longer need to create any classes.." (not sure why you used the word "custom"?)
Lines 167 onwards seem to be included by mistake?

The section regarding the manifest is going to need some refinement, since the changes in 12.1 have broken the manifest merge that worked up until 12.0. It will need to advise users of 12.1 or later to make the changes that would have occurred if the merge worked.

@Ztaclie
Copy link
Contributor Author

Ztaclie commented Nov 28, 2024

Hi ,

I have made the changes as per your feedback:

  1. Updated line 8 to read "multiple lines of text.
  2. "Replaced "custom" with "any" on line 11.
  3. Removed the unintended lines from 167 onwards.
  4. Refined the Android manifest section to address the changes required for Delphi 12.1 or later, including a note on manually applying the changes due to the broken manifest merge.

Please let me know if there are any additional adjustments needed. Thank you for your review and guidance!

@DelphiWorlds
Copy link
Owner

@Ztaclie
Copy link
Contributor Author

Ztaclie commented Nov 28, 2024

Hi,

Unintended lines magically doesn't stashed i fixed this and pushed again sorry for the inconvenience.

please let me know if there are any additional adjustments needed. Thank you for your review and guidance!

@DelphiWorlds DelphiWorlds merged commit d98294b into DelphiWorlds:master Nov 28, 2024
1 check passed
@DelphiWorlds
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants