Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fix react native support #1382

Merged
merged 11 commits into from
Apr 20, 2023
Merged

feat: Fix react native support #1382

merged 11 commits into from
Apr 20, 2023

Conversation

fundthmcalculus
Copy link
Contributor

@fundthmcalculus fundthmcalculus commented Apr 20, 2023 •
edited
Loading

Tested

  • Node-XHR (node doesn't provide XMLHttpRequest out of the box)
  • Node-NodeHttp (default)
  • Node-Fetch (Works on Node-18+)
  • Web-XHR (looks like issues with Karma)
  • Web-NodeHttp (impossible)
  • Web-Fetch (default)
  • React Native-Android
  • React Native-iOS
  • Expo-Android
  • Expo-iOS

@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com April 20, 2023 14:47 — with GitHub Actions Inactive
@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com April 20, 2023 17:32 — with GitHub Actions Inactive
@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com April 20, 2023 20:12 — with GitHub Actions Inactive
@fundthmcalculus fundthmcalculus temporarily deployed to npmjs.com April 20, 2023 20:48 — with GitHub Actions Inactive
@fundthmcalculus fundthmcalculus added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit a13ba63 Apr 20, 2023
@fundthmcalculus fundthmcalculus deleted the fix-react-native branch April 20, 2023 20:54
@fundthmcalculus
Copy link
Contributor Author

@tmarkovski I confirmed the fix for your protobufjs/minimal dependency issue with RC5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmarkovski tmarkovski tmarkovski approved these changes

@janpieterz janpieterz Awaiting requested review from janpieterz

@geel9 geel9 Awaiting requested review from geel9

@chiarapaskulin chiarapaskulin Awaiting requested review from chiarapaskulin

@lucasamonrc lucasamonrc Awaiting requested review from lucasamonrc

@Hmac512 Hmac512 Awaiting requested review from Hmac512

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fundthmcalculus @tmarkovski