-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bundling CLI and minor updates #22
base: master
Are you sure you want to change the base?
Conversation
tasks.withType<KotlinCompile>() { | ||
kotlinOptions.jvmTarget = "1.8" | ||
java { | ||
toolchain.languageVersion = JavaLanguageVersion.of(11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
com.android.tools
requires Java 11 or newer.
Hey @DevSrSouza just want you to know this PR's content would be useful at virtually every job I've had as a design system engineer. There is a dire need of tools to convert SVG icons to code straight from a source of truth, especially for Android. |
@Sidnioulz You can try out https://github.com/ComposeGears/Valkyrie. |
@Goooler I found this project via your issue on Valkyrie :) I also wrote on the Valkyrie Slack yesterday. I understand it's not production-ready either? |
If you need this CLI, I'll try to finish it in Valkyrie, so busy for now... |
I do not want to rush you at all! I know first-hand opensource takes time 😄 And I'd like to use the opportunity to thank you for your work ❤️ I just wanted to know DevSrSouza of this use case because I believe the people building these tools don't necessarily know about the design system use case. |
Closes #23.
We can keep this repo update to date by enabling @renovate-bot.