Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiernft testnet #228

Merged
merged 5 commits into from
May 28, 2024
Merged

Update tiernft testnet #228

merged 5 commits into from
May 28, 2024

Conversation

elPiablo
Copy link
Contributor

@elPiablo elPiablo commented Apr 19, 2024

from issue: #227 (comment)

Changes needed

Mumbai is being retired. TierNFT lesson and Connect to Front-end lessons need upgraded:

https://polygon.technology/blog/polygon-pos-is-cooking-the-napoli-upgrade-means-better-ux-the-mumbai-testnet-takes-a-bow

  • remove reference to "scripts/ where simple automation scripts go"
  • change to:
    rm contracts/*.sol
    rm test/*.js
    by removing rm scripts/*.js as it doesn't come with the build anymore
  • learner must create scripts/deploy.js dir and file
  • change hardhat.config.js with new RPC details: https://polygon.technology/blog/polygon-pos-and-polygon-zkevm-new-testnets-for-polygon-protocols for Amoy Testnet
  • update "Adding the testnet network paragraph with new details 👆🏼
    ..
  • This one is not a deal breaker, but it would be nice to know how do I do grab the path to this? Typically it would be: [Introduction to web3 Wallets](../../../pages/fundamentals/wallets.mdx) but it returns a 404 page error
    ..
  • asset update screenshot from Mumbai to Amoy
  • check if URL for test token faucet is correct - add alternatives or additional URL possibilites
  • asset update screenshot re: faucet if necessary
  • under Personal Security paragraph, format the current paragraph from text to a bulleted list for Zerion steps
    ..
  • change deploy command to npx hardhat run scripts/deploy.js --network amoy
  • asset update screenshot for deploy terminal output
  • change mint command to npx hardhat run scripts/mint.js --network amoy
  • asset update screenshot for mint terminal output
  • asset update OpenSea (if possible) with link to new NFTs
  • create lesson summary
  • update titles of other lessons when they're referenced, e.g. in intro and outro

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 0:52am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 0:52am

Copy link

github-actions bot commented Apr 19, 2024

Running Lighthouse audit...

@elPiablo
Copy link
Contributor Author

elPiablo commented Apr 23, 2024

Hey @Markkos89

How would I add a path (inside the TierNFT lesson) to this lesson on web3 wallets which is inside Fundamentals?

Typically we would do this: [Introduction to web3 Wallets](../../../pages/fundamentals/wallets.mdx), but I get a 404 error, so I guess our Next.js config doesn't allow us to use this standard path, right?

It's not a deal breaker for this PR. I was just wondering how we can easily use links to bring the learner to other areas of the platform. Sometimes very handy.

Just so you know where I'm trying to put it in, here's a screenshot from TierNFT lesson's .mdx:
trying to get path to web3 wallets lesson

@elPiablo elPiablo requested review from wolovim and Markkos89 April 23, 2024 01:19
@elPiablo elPiablo added ready to review content Content & pedagogy related labels Apr 23, 2024
@elPiablo elPiablo requested a review from briangershon May 27, 2024 12:10
@elPiablo
Copy link
Contributor Author

elPiablo commented May 27, 2024

@Markkos89 could you do a quick review of this?
and regarding this:

This one is not a deal breaker, but it would be nice to know how do I do grab the path to this? Typically it would be: Introduction to web3 Wallets but it returns a 404 page error

is there an easy way to implement this path as a simple URL to grab this lesson from Fundamentals? or do we need to add it as a component? It's not super important btw.

@elPiablo elPiablo merged commit 879f980 into staging May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content & pedagogy related ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant