Preserve exception stack traces during reflection-based invocation #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the robustness of the
EventSubscriber.Invoke<T>
method by preserving the original exception context when invoking methods via reflection.Problem
When using
MethodInfo.Invoke(...)
, if an exception occurs, it is wrapped inside aTargetInvocationException
, which causes the original stack trace to be lost. This makes debugging much harder, especially when exceptions are thrown deep inside event handlers or predicates.Changes
_predicateMethod.Invoke(...)
and_callbackMethod.Invoke(...)
inside try-catch blocks.ExceptionDispatchInfo.Capture(...).Throw()
to re-throw the inner exception while preserving its original stack trace.Impact