Improve window creation #767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ECF_BORDERLESS - ECF_UI_RESIZABLE and ECF_PROGRAM_RESIZABLE - ECF_MINIMIZED - ECF_MOUSE_CAPTURE - ECF_ALWAYS_ON_TOP Signed-off-by: Ali Cheraghi <[email protected]>
Signed-off-by: Ali Cheraghi <[email protected]>
Erfan-Ahmadi
reviewed
Nov 8, 2024
| creationParams.flags |= IWindow::ECF_CAN_RESIZE; | ||
| if (creationParams.flags.hasFlags(IWindow::ECF_CAN_MAXIMIZE) || creationParams.flags.hasFlags(IWindow::ECF_CAN_MINIMIZE)) | ||
| creationParams.flags |= IWindow::ECF_UI_RESIZABLE; | ||
| if (creationParams.flags.hasFlags(IWindow::ECF_FULLSCREEN)) |
There was a problem hiding this comment.
Hmm I wonder why games have full screen vs windowed borderless fullscreen, do we need to consider this as well? Why are you adding borderless flag when you detect fullscreen?
There was a problem hiding this comment.
i did some researching and apparently in windows, the only difference between fullscreen and windowed borderless fullscreen is that the former has the HWND_TOPMOST flag. so:
- fullscreen:
borderless + always-on-top + monitor sized - windowed borderless fullscreen:
borderless + monitor sized
Signed-off-by: Ali Cheraghi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Hello Swapchain
TODO list:
ECF_FULLSCREENECF_MAXIMIZEDMultiple monitorsswitch from/to fullscreen