Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ngfx sdk integration #777

Merged
merged 12 commits into from
Dec 31, 2024
Merged

Ngfx sdk integration #777

merged 12 commits into from
Dec 31, 2024

Conversation

devshgraphicsprogramming
Copy link
Member

Description

Testing

TODO list:

@keptsecret
Copy link
Contributor

Still haven't been able to test because it needs to link dll on compile

@devshgraphicsprogramming
Copy link
Member Author

Still haven't been able to test because it needs to link dll on compile

You need @AnastaZIuk to figure out the Delay DLL loading for the ngfx dll in a way that it makes sense (probably similar to renderdoc's dll load).

Also the code we have needs to be resilient to DLL not being found, so we need to NOT call NGFX if the DLL was not delay loaded properly.

…creating interface `ngfx` interface target on success, allow for picking found versions
@AnastaZIuk
Copy link
Member

Still haven't been able to test because it needs to link dll on compile

You need @AnastaZIuk to figure out the Delay DLL loading for the ngfx dll in a way that it makes sense (probably similar to renderdoc's dll load).

Also the code we have needs to be resilient to DLL not being found, so we need to NOT call NGFX if the DLL was not delay loaded properly.

done as part of #789

@devshgraphicsprogramming devshgraphicsprogramming merged commit 2b3bdaa into master Dec 31, 2024
1 check failed
@devshgraphicsprogramming devshgraphicsprogramming deleted the ngfx-sdk-integration branch December 31, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants