newBuildSystem post master merge compile fixes & updates

[AnastaZIuk]

No description provided.

[AnastaZIuk]

this should be silent check, no logs

[AnastaZIuk]

have a NBL_3RDPARTY_IMMUTABLE_TARGET_SRC_PATTERNS list, put "${NBL_ROOT_PATH}/3rdparty/dxc*" and "${NBL_ROOT_PATH}/3rdparty/libjpeg-turbo*" into the list, & use it to perform the regex pattern check

[AnastaZIuk]

# you can move this util to common.cmake
function(NBL_MATCH_PATTERNS IN_STRING PATTERNS_VAR RESULT_VAR)
    set(NBL_MATCHED FALSE)

    foreach(PATTERN IN LISTS ${PATTERNS_VAR})
        if(${IN_STRING} MATCHES "${PATTERN}")
            set(NBL_MATCHED TRUE)
            break()
        endif()
    endforeach()

    set(${RESULT_VAR} ${NBL_MATCHED} PARENT_SCOPE)
endfunction()

set(NBL_3RDPARTY_IMMUTABLE_TARGET_SRC_PATTERNS
    "${NBL_ROOT_PATH}/3rdparty/dxc*"
    "${NBL_ROOT_PATH}/3rdparty/libjpeg-turbo*"
)

NBL_GET_ALL_TARGETS(NBL_ALL_3RDPARTY_TARGETS)

foreach(NBL_TARGET IN LISTS NBL_ALL_3RDPARTY_TARGETS)
    get_target_property(NBL_TARGET_SOURCE_DIR ${NBL_TARGET} SOURCE_DIR)
    NBL_MATCH_PATTERNS("${NBL_TARGET_SOURCE_DIR}" NBL_3RDPARTY_IMMUTABLE_TARGET_SRC_PATTERNS MATCH_FOUND)

    if(MATCH_FOUND)
        list(APPEND NBL_IMMUTABLE_TARGETS ${NBL_TARGET})
    else()
        list(APPEND NBL_MUTABLE_TARGETS ${NBL_TARGET})
    endif()
endforeach()

[AnastaZIuk]

by the way why do we treat libjpeg-turbo as immutable?

[AnastaZIuk]

don't use this util second time here, at this point we don't add any new 3rdparty targets so you do the same job twice (its recursive function going through all processed CMakeLists.txt files so far inclusive down bellow your current node in the build tree), we should call it only once just before updating their properties/compile options, definitions or whatever

[AnastaZIuk]

parent scope immutable & mutable target lists as well