Hlsl bxdfs 2 #811
Open
Hlsl bxdfs 2 #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keptsecret
reviewed
Feb 25, 2025
There was a problem hiding this comment.
I don't see any changes here. Don't know why it shows up from the merge. Probably just line endings?
There was a problem hiding this comment.
whitespace or GH apeing out.
There was a problem hiding this comment.
yeah when you use "ignore whitespace" it says "Whitespace-only changes"
Comment on lines
+619
to
+658
| #ifdef __HLSL_VERSION | ||
| template<class T> | ||
| struct rank : integral_constant<uint64_t, | ||
| conditional_value< | ||
| is_matrix_v<T>, | ||
| uint64_t, | ||
| 2ull, | ||
| conditional_value< | ||
| is_vector_v<T>, | ||
| uint64_t, | ||
| 1ull, | ||
| 0ull | ||
| >::value | ||
| >::value | ||
| > { }; | ||
|
|
||
| template<class T, uint64_t N> | ||
| struct rank<T[N]> : integral_constant<uint64_t, 1 + rank<T>::value> { }; | ||
|
|
||
| template<class T> | ||
| struct rank<T[]> : integral_constant<uint64_t, 1 + rank<T>::value> { }; | ||
|
|
||
| template<class T, uint32_t I = 0 NBL_STRUCT_CONSTRAINABLE> | ||
| struct extent : integral_constant<uint64_t, 0> {}; | ||
|
|
||
| template<class T, uint64_t N> | ||
| struct extent<T[N], 0> : integral_constant<uint64_t, N> {}; | ||
|
|
||
| template<class T, uint64_t N, uint32_t I> | ||
| struct extent<T[N], I> : integral_constant<uint64_t,extent<T, I - 1>::value> {}; | ||
|
|
||
| template<class T, uint32_t I> | ||
| struct extent<T[], I> : integral_constant<uint64_t,extent<T, I - 1>::value> {}; | ||
|
|
||
| template<class T, uint16_t N> | ||
| struct extent<vector<T,N>, 0> : integral_constant<uint64_t, N> {}; | ||
|
|
||
| template<class T, uint16_t M, uint16_t N, uint32_t I> | ||
| struct extent<matrix<T,N,M>, I> : integral_constant<uint64_t,extent<T[N][M], I>::value> {}; | ||
| #endif |
There was a problem hiding this comment.
why did you make these HLSL only? they should work in C++ and HLSL both!
@Przemog1 guide how to implement
There was a problem hiding this comment.
The C++ version already uses std::rank and std::extent?
Comment on lines
606
to
623
| // Template Variables | ||
| template<typename A, typename B> | ||
| NBL_CONSTEXPR bool is_same_v = is_same<A, B>::value; | ||
| template<class T> | ||
| NBL_CONSTEXPR bool is_unsigned_v = is_unsigned<T>::value; | ||
| template<class T> | ||
| NBL_CONSTEXPR bool is_integral_v = is_integral<T>::value; | ||
| template<class T> | ||
| NBL_CONSTEXPR bool is_floating_point_v = is_floating_point<T>::value; | ||
| template<class T> | ||
| NBL_CONSTEXPR bool is_signed_v = is_signed<T>::value; | ||
| template<class T> | ||
| NBL_CONSTEXPR bool is_scalar_v = is_scalar<T>::value; | ||
| template<class T> | ||
| NBL_CONSTEXPR uint32_t alignment_of_v = alignment_of<T>::value; | ||
| template<class T, uint32_t N = 0> | ||
| NBL_CONSTEXPR uint64_t extent_v = extent<T, N>::value; | ||
|
|
There was a problem hiding this comment.
only extent_v should have moved, rest should have stayed where they were
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recreated PR #797 because GitHub diff browser glitched.
Testing
TODO list: