Update to v1.4.307 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [fsfe/reuse-action](https://github.com/fsfe/reuse-action) from 2 to 3. - [Release notes](https://github.com/fsfe/reuse-action/releases) - [Commits](fsfe/reuse-action@v2...v3) --- updated-dependencies: - dependency-name: fsfe/reuse-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
This makes the project more composable: It can be built and tested as part of a larger set of projects, from source.
- Guarded behind `if()` version and compiler test - Linked to `Vulkan-Headers` as a dependency - Also added `CXX` to the `LANGUAGES` property of the project
Installing a C++ module in CMake isn't something which is well defined currently. Rather than add code which behaves poorly or flat out wrong, it is better to not try to install a binary module for the time being. The vulkan.cppm file is still included in the install so downstream users can still create a module from it.
This tests the Vulkan Module building without needing to run inside an integration test. While theoretically the integration tests will exercise the build, the nature of running the build inside of a test makes it more difficult to diagnose if the test is poorly setup or if the build itself isn't working.
Adds the VULKAN_HEADERS_ENABLE_MODULE option to control whether to build the Vulkan-Hpp module. This is necessary to allow CI to pass while waiting for the MSVC version 17.11, which fixes an internal compiler bug, to be added to github actions runners.
…date Motivated by recent problems building the SC 1.0.15 spec update - will import to VulkanSC-Headers and tweak once it's proven out for Vulkan-Headers. The Makefile may need to be modified when directory structure is changed or new files are added.
Bumps [fsfe/reuse-action](https://github.com/fsfe/reuse-action) from 3 to 4. - [Release notes](https://github.com/fsfe/reuse-action/releases) - [Commits](fsfe/reuse-action@v3...v4) --- updated-dependencies: - dependency-name: fsfe/reuse-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
17.10 and before has a bug that prevents the vulkan.cppm module from compiling. The module support wont be enabled unless the MSVC version contains the fix.
The current released versions of clang-cl does not work with CMakes module implementation. Rather than break downstream users, just disable the module support for the time being.
clang ships the clang-scan-deps tool separately from the compiler, making it possible that the clang compiler supports modules but cannot be used by CMake for VulkanHppModule. The straightforward solution is to, when using clang, check that the scan deps tools was located. This prevents people who are using clang but not the modules from being unable to use Vulkan-Headers when the clang-scan-deps tools is missing.
Can't use `MSVC` var because it is also true for clang-cl. Fixes KhronosGroup#500.
After numerous reports of builds being broken due to the addition of the Vulkan-Module support code in CMake, the option is being set to OFF by default. This prevents projects which do not use the module from not being able to build due to compiler, build system, and platform issues. Projects wishing to enable modules can set the cmake option VULKAN_HEADERS_ENABLE_MODULE=ON to re-enable the module support. Add a warning in case a user decides to enable the module but the platform doesn't support modules.
Bumps [fsfe/reuse-action](https://github.com/fsfe/reuse-action) from 4 to 5. - [Release notes](https://github.com/fsfe/reuse-action/releases) - [Commits](fsfe/reuse-action@v4...v5) --- updated-dependencies: - dependency-name: fsfe/reuse-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.