Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse internal type definitions #216

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

Mad-Kat
Copy link
Collaborator

@Mad-Kat Mad-Kat commented Nov 23, 2024

To improve maintainability of the types, particularly for keyframes and css, this PR reuses definitions from the internal types.

Copy link

changeset-bot bot commented Nov 23, 2024

🦋 Changeset detected

Latest commit: 9eaf927

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #216 will not alter performance

Comparing deduplicate-type-definitions (9eaf927) with main (fb2b2ca)

Summary

✅ 2 untouched benchmarks

@Mad-Kat Mad-Kat marked this pull request as ready for review November 23, 2024 11:28
@Mad-Kat Mad-Kat requested a review from jantimon November 23, 2024 11:28
Add empty changeset

[autofix.ci] apply automated fixes
@Mad-Kat Mad-Kat force-pushed the deduplicate-type-definitions branch from 3f98c06 to 9eaf927 Compare November 25, 2024 12:27
@Mad-Kat Mad-Kat merged commit 94354f3 into main Nov 26, 2024
8 checks passed
jantimon pushed a commit that referenced this pull request Nov 29, 2024
@jantimon jantimon deleted the deduplicate-type-definitions branch November 29, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants