Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't infer types of selectors in mixins #217

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

Mad-Kat
Copy link
Collaborator

@Mad-Kat Mad-Kat commented Nov 23, 2024

Closes #218

Copy link

changeset-bot bot commented Nov 23, 2024

🦋 Changeset detected

Latest commit: e746c47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
next-yak Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mad-Kat Mad-Kat force-pushed the deduplicate-type-definitions branch from 3f98c06 to 9eaf927 Compare November 25, 2024 12:27
@Mad-Kat Mad-Kat changed the base branch from deduplicate-type-definitions to main November 26, 2024 14:20
@Mad-Kat Mad-Kat force-pushed the dont-infer-types-of-selector-mixins branch from aee856f to dd4bf7f Compare November 26, 2024 14:24
Copy link

codspeed-hq bot commented Nov 26, 2024

CodSpeed Performance Report

Merging #217 will not alter performance

Comparing dont-infer-types-of-selector-mixins (e746c47) with main (411ad36)

Summary

✅ 2 untouched benchmarks

@Mad-Kat Mad-Kat marked this pull request as ready for review November 26, 2024 14:50
@Mad-Kat Mad-Kat requested a review from jantimon November 26, 2024 14:51
@Mad-Kat Mad-Kat merged commit 365af90 into main Nov 29, 2024
8 checks passed
@Mad-Kat Mad-Kat deleted the dont-infer-types-of-selector-mixins branch November 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Mixins with selectors only should not alter type of component
2 participants