Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all obsolete loader files #219

Merged
merged 14 commits into from
Nov 29, 2024
Merged

Conversation

Mad-Kat
Copy link
Collaborator

@Mad-Kat Mad-Kat commented Nov 24, 2024

With the switch to SWC, we have also changed our approach in the loaders. Hereby I remove the files that are no longer needed to have a better understandable structure.

Copy link

changeset-bot bot commented Nov 24, 2024

🦋 Changeset detected

Latest commit: 880af09

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Nov 24, 2024

CodSpeed Performance Report

Merging #219 will degrade performances by 14.34%

Comparing remove-obsolete-loader-files (880af09) with main (6f6f43b)

Summary

❌ 1 (👁 1) regressions
✅ 1 untouched benchmarks

Benchmarks breakdown

Benchmark main remove-obsolete-loader-files Change
👁 render KanjiLetterComponentYak 273.6 ms 319.5 ms -14.34%

@Mad-Kat Mad-Kat marked this pull request as ready for review November 24, 2024 17:59
@Mad-Kat Mad-Kat requested a review from jantimon November 24, 2024 17:59
@jantimon jantimon merged commit eabe5d8 into main Nov 29, 2024
8 checks passed
@jantimon jantimon deleted the remove-obsolete-loader-files branch November 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants