Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm catalog #249

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Use pnpm catalog #249

merged 4 commits into from
Jan 7, 2025

Conversation

Mad-Kat
Copy link
Collaborator

@Mad-Kat Mad-Kat commented Dec 29, 2024

With version 9.5.0, pnpm added the ability to specify the versions of all packages centrally. I've run the codemod and changed the minimum version to 9.7.0, as they added the ability to manage package manger versions that we already specify in our root package.json.

Copy link

changeset-bot bot commented Dec 29, 2024

🦋 Changeset detected

Latest commit: 4eb5202

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Dec 29, 2024

CodSpeed Performance Report

Merging #249 will not alter performance

Comparing use-pnpm-catalog (4eb5202) with main (e14d265)

Summary

✅ 2 untouched benchmarks

@Mad-Kat Mad-Kat marked this pull request as ready for review December 29, 2024 14:56
@Mad-Kat Mad-Kat requested a review from jantimon December 29, 2024 14:57
Copy link

@KrzysztofKarol KrzysztofKarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine

Copy link
Collaborator

@jantimon jantimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a way to prevent npm publish otherwise dependencies: { "yak-swc": "catalog:" } would be published to npm and break on install

Also we might consider splitting the catalog into our core dependencies (which will change the behaviour once we publish to npm) and a dev dependency catalog (which includes docs, vitest, ...)

@Mad-Kat Mad-Kat requested a review from jantimon January 6, 2025 12:29
@Mad-Kat Mad-Kat merged commit 10adce8 into main Jan 7, 2025
8 checks passed
@Mad-Kat Mad-Kat deleted the use-pnpm-catalog branch January 7, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants