-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pnpm catalog #249
Use pnpm catalog #249
Conversation
🦋 Changeset detectedLatest commit: 4eb5202 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #249 will not alter performanceComparing Summary
|
acba857
to
47501f5
Compare
47501f5
to
900c0e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a way to prevent npm publish
otherwise dependencies: { "yak-swc": "catalog:" }
would be published to npm and break on install
Also we might consider splitting the catalog into our core dependencies (which will change the behaviour once we publish to npm) and a dev dependency catalog (which includes docs, vitest, ...)
With version 9.5.0, pnpm added the ability to specify the versions of all packages centrally. I've run the codemod and changed the minimum version to 9.7.0, as they added the ability to manage package manger versions that we already specify in our root
package.json
.