Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css prop in exported component #253

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

Mad-Kat
Copy link
Collaborator

@Mad-Kat Mad-Kat commented Dec 30, 2024

Closes #252

Handling a css prop should take precedence over exported mixins.

@Mad-Kat Mad-Kat marked this pull request as ready for review December 30, 2024 13:56
@Mad-Kat Mad-Kat requested a review from jantimon December 30, 2024 13:56
jantimon
jantimon previously approved these changes Dec 30, 2024
@Mad-Kat Mad-Kat force-pushed the update-dependencies branch 2 times, most recently from f2bd1cc to d1eda5e Compare January 7, 2025 12:38
Base automatically changed from update-dependencies to main January 7, 2025 13:58
@Mad-Kat Mad-Kat dismissed jantimon’s stale review January 7, 2025 13:58

The base branch was changed.

@Mad-Kat Mad-Kat force-pushed the fix-css-prop-in-exported-component branch from 7b7ead0 to 1e840a7 Compare January 7, 2025 18:47
Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 647bf4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
next-yak Patch
yak-swc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #253 will not alter performance

Comparing fix-css-prop-in-exported-component (647bf4d) with main (d4379a2)

Summary

✅ 2 untouched benchmarks

@Mad-Kat Mad-Kat requested a review from jantimon January 8, 2025 08:19
@Mad-Kat Mad-Kat merged commit 171898f into main Jan 8, 2025
8 checks passed
@Mad-Kat Mad-Kat deleted the fix-css-prop-in-exported-component branch January 8, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CSS prop doesn't work when component that uses it is exported
2 participants