Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline constants #63

Merged

Conversation

jantimon
Copy link
Collaborator

@jantimon jantimon commented Feb 7, 2024

No description provided.

Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yacijs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 2:08pm

Copy link

codspeed-hq bot commented Feb 7, 2024

CodSpeed Performance Report

Merging #63 will not alter performance

Comparing feature/inline-constant-values-for-numbers-and-strings (58075e0) with main (6df516d)

Summary

✅ 2 untouched benchmarks

Copy link
Collaborator

@Mad-Kat Mad-Kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the wrapping of the values in a new Token, but I'm maybe mistaken :)

What do you think?

@jantimon jantimon merged commit 64cacab into main Feb 7, 2024
6 checks passed
@jantimon jantimon deleted the feature/inline-constant-values-for-numbers-and-strings branch July 15, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants