Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add square-bracket-support #66

Merged
merged 4 commits into from
Feb 9, 2024
Merged

add square-bracket-support #66

merged 4 commits into from
Feb 9, 2024

Conversation

jantimon
Copy link
Collaborator

@jantimon jantimon commented Feb 9, 2024

we got a request to support numeric indexes for yak files e.g.:

import { spacings } from "./constants.yak";

const Button = styled.button`
   margin: ${spacings[0]}
`

this pr uses recursions to allow any combination of computed and uncomputed member expressions like for example:

a.usage["of"][5].member.expressions

Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yacijs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 8:40am

Copy link

codspeed-hq bot commented Feb 9, 2024

CodSpeed Performance Report

Merging #66 will not alter performance

⚠️ No base runs were found

Falling back to comparing square-bracket-support (22ddff4) with main (64cacab)

Summary

✅ 2 untouched benchmarks

@jantimon jantimon requested a review from Mad-Kat February 9, 2024 08:18
@jantimon jantimon merged commit 349e2e2 into main Feb 9, 2024
6 checks passed
@jantimon jantimon deleted the square-bracket-support branch July 15, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants