Fix Unity version parameter compilation errors

[bdovaz]

No description provided.

[bdovaz]

@FejZa I have realized that when I have corrected the compilation error I have actually generated another problem.

Before when I didn't know that "getUnityEditorVersion()" returned an object of type "UnityVersionInfoResult" instead of a string (what I thought) it was going to evaluate right because if getInput() is null, it evaluates the one on the right.

But when I realized that I had to return an object of type "UnityVersionInfoResult" now I always return an instance of it so it will always evaluate the left hand side as non-null but with the version property to null if getInput() is null.

That problem needs to be fixed, will you take care of it or shall I help you?

https://github.com/Dinomite-Studios/unity-azure-pipelines-tasks/pull/206/files#diff-8bb3905afc0c9f7674a34175cd57333ea9f52749a21dd1d8978b2263a3a133f4R33

[derekfreed]

@FejZa I have realized that when I have corrected the compilation error I have actually generated another problem.

Before when I didn't know that "getUnityEditorVersion()" returned an object of type "UnityVersionInfoResult" instead of a string (what I thought) it was going to evaluate right because if getInput() is null, it evaluates the one on the right.

But when I realized that I had to return an object of type "UnityVersionInfoResult" now I always return an instance of it so it will always evaluate the left hand side as non-null but with the version property to null if getInput() is null.

That problem needs to be fixed, will you take care of it or shall I help you?

https://github.com/Dinomite-Studios/unity-azure-pipelines-tasks/pull/206/files#diff-8bb3905afc0c9f7674a34175cd57333ea9f52749a21dd1d8978b2263a3a133f4R33

@bdovaz / @FejZa
I have a suspicion that this issue over here may be related to this new problem you outlined.

It seems that my unitytest task won't work unless I explicitly specify the unityversion which was not the old behavior since it would correctly get the unity version if I did not specify it.

I know this was a while ago, but do you have a fix for this?

I'm thinking we could do something like the following to make sure the unityversion is evaluated properly:

const unityVersionInput = tl.getInput(unityVersionInputVariableName);
const unityVersion = unityVersionInput ? { info: { version: unityVersionInput } } as UnityVersionInfoResult : getUnityEditorVersion();

[derekfreed]

I just opened a PR which hopes to resolve this #257