Skip to content

Commit

Permalink
Fix proxy (#2108)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkelleyrtp authored Mar 19, 2024
1 parent d8942a2 commit 10d361a
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 13 deletions.
45 changes: 36 additions & 9 deletions packages/cli/src/server/web/proxy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -65,16 +65,43 @@ pub fn add_proxy(mut router: Router, proxy: &WebProxyConfig) -> Result<Router> {

let client = ProxyClient::new(url);

let method_router = any(move |mut req: Request<MyBody>| async move {
// Prevent request loops
if req.headers().get("x-proxied-by-dioxus").is_some() {
return Err((
StatusCode::NOT_FOUND,
"API is sharing a loopback with the dev server. Try setting a different port on the API config."
.to_string(),
));
}

req.headers_mut().insert(
"x-proxied-by-dioxus",
"true".parse().expect("header value is valid"),
);

client
.send(req)
.await
.map_err(|e| (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()))
});

// api/*path
router = router.route(
// Always remove trailing /'s so that the exact route
// matches.
&format!("/*{}", trimmed_path.trim_end_matches('/')),
any(move |req: Request<MyBody>| async move {
client
.send(req)
.await
.map_err(|e| (StatusCode::INTERNAL_SERVER_ERROR, e.to_string()))
}),
&format!("/{}/*path", trimmed_path.trim_end_matches('/')),
method_router.clone(),
);

// /api/
router = router.route(
&format!("/{}/", trimmed_path.trim_end_matches('/')),
method_router.clone(),
);

// /api
router = router.route(
&format!("/{}", trimmed_path.trim_end_matches('/')),
method_router,
);

Ok(router)
Expand Down
3 changes: 0 additions & 3 deletions packages/hot-reload/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,6 @@ pub fn connect(mut callback: impl FnMut(HotReloadMsg) + Send + 'static) {
}

let Ok(template) = serde_json::from_str(Box::leak(buf.into_boxed_str())) else {
eprintln!(
"Could not parse hot reloading message - make sure your client is up to date"
);
continue;
};

Expand Down
1 change: 0 additions & 1 deletion packages/web/src/eval.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
use core::panic;
use dioxus_html::prelude::{EvalError, EvalProvider, Evaluator};
use futures_util::StreamExt;
use generational_box::{AnyStorage, GenerationalBox, UnsyncStorage};
Expand Down

0 comments on commit 10d361a

Please sign in to comment.