Fix #2104: fmt incorrectly using 1-indexing for columns #2106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dx fmt
breaks file #2104Two issues in autofmt:
While doing this overhaul, I also finally ditched the prettier-please crate for the original prettyplease crate, meaning we have 1 fewer vendored crates to maintain (bringing that down the total down to 0!). This does lead to slightly less performance (since we can't make a
File
out of a borrowedExpr
, but should be imperceptible in practice.