-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the stylesheet component #3176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
unlike |
This PR fixes that issue (here) |
Missed that, apologies! |
I don't want to remove the Stylesheet component. Just coming from a world of html I'm not sure I would know to reach for But, we did need to fix the bug with Style not applying the |
This PR removes the stylesheet component. The
Style
component already renders a stylesheetlink
in the head if you pass in a link instead of inline CSS.Stylesheet
is just a less general version of theStyle
component. The two components have a very similar name and the exact same purpose which could cause confusionReverts #3138