Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support axum 0.8 #3820

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CristianCapsuna
Copy link

@CristianCapsuna CristianCapsuna commented Mar 3, 2025

Hi guys. Very excited to make my first, small, contribution.

Before this PR can be closed, the server_fn and server_fn_macro dependencies need to be pointed to their released crates once those are available.

I was not able to do the make tests but I don't think it's because of this. See below. Any guidance on how I could make this work?
Screenshot from 2025-03-03 16-07-33

I plugged this is my wannabe website project and it worked fine.

@CristianCapsuna CristianCapsuna requested a review from a team as a code owner March 3, 2025 16:08
@CristianCapsuna
Copy link
Author

CristianCapsuna commented Mar 4, 2025

The change to the cli/src/serve/server.rs was done after reading this.

Are there any other tests I should do for the fullstack-auth example? Personally I am not fond of it. I have chosen to use Max Countryman's tower-sessions and axum-login as I found them easier to understand. The community seems to agree with that sentiment looking at the stars for the repos. At some point I will make an example for it.

Lastly, I noted that the command used in the CI/CD pipeline for checking is cargo check --workspace --all-features --all-targets. The latest version of the Contributing page suggests using cargo check --workspace --examples --tests. The former does not show any issues where latter does. Is there a way to submit an update to the docs page?

@CristianCapsuna
Copy link
Author

@ealmloff would you have any guidance on what the problem is with the playwright test?

@ealmloff
Copy link
Member

ealmloff commented Mar 7, 2025

@ealmloff would you have any guidance on what the problem is with the playwright test?

My guess is some of the CLI changes are causing it to not proxy the fullstack server. Try going into one of the playwright tests and running the server command manually then opening the site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants