Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "USE_CLYDE_AI" permission #1090

Closed
wants to merge 15 commits into from
Closed

Add "USE_CLYDE_AI" permission #1090

wants to merge 15 commits into from

Conversation

MCausc78
Copy link

Summary

discord/discord-api-docs#6354

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@MCausc78 MCausc78 changed the title Add Add "USE_CLYDE_AI" permission Aug 14, 2023
@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Aug 14, 2023
docs: clarify `Guild.fetch_member` raised exceptions (#1089)
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR - a couple comments, mostly regarding documentation.

Additionally, since this implicitly gets denied when you can't send messages in a channel, it needs to be added in these two places as well:

disnake/disnake/abc.py

Lines 639 to 644 in f08edf8

if not base.send_messages:
base.send_tts_messages = False
base.send_voice_messages = False
base.mention_everyone = False
base.embed_links = False
base.attach_files = False

disnake/disnake/threads.py

Lines 474 to 479 in f08edf8

if not base.send_messages_in_threads:
base.send_tts_messages = False
base.send_voice_messages = False
base.mention_everyone = False
base.embed_links = False
base.attach_files = False

changelog/1090.feature.rst Outdated Show resolved Hide resolved
disnake/permissions.py Outdated Show resolved Hide resolved
disnake/permissions.py Show resolved Hide resolved
@MCausc78 MCausc78 requested a review from shiftinv August 17, 2023 19:22
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@MCausc78
Copy link
Author

MCausc78 commented Sep 3, 2023

@spifory
Copy link
Contributor

spifory commented Sep 3, 2023

discord/discord-api-docs#6398

Please could you add this into a separate PR and not this one, just so there isn't any scope creep

@shiftinv
Copy link
Member

shiftinv commented Jan 2, 2024

Clyde was deactivated about a month ago (o7), so this is no longer needed.
thank you for the PR, nonetheless

@shiftinv shiftinv closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation t: api support Support of Discord API features t: enhancement New feature
Projects
Status: Needs Merge
Development

Successfully merging this pull request may close these issues.

3 participants