feat: add Invite.type
#1142
Merged
feat: add Invite.type
#1142
+73
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is technically not required since both of these fields have fallbacks, but still good practice nonetheless.
shiftinv
added
t: enhancement
Victorsitou
reviewed
Mar 20, 2024
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
elenakrittik
approved these changes
May 16, 2024
shiftinv
removed
the
s: waiting for api/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for invite types. This also resolves an old
TODOregarding null channels in invites, since friend invites do not link to a specific resource.I don't think friend invites ever shipped, but the type is included regardless to match the linked PR.
Checklist
pdm lintpdm pyright