Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update required permissions for prune #1161

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

vcokltfre
Copy link
Member

Summary

Update the documentation to reflect discord/discord-api-docs#6685

This is a single-word docs-only change, no code has been updated, so testing/etc have been skipped.

@vcokltfre vcokltfre marked this pull request as draft March 1, 2024 19:43
@vcokltfre
Copy link
Member Author

Draft as the docs change isn't solidified yet, but when it is this can be merged.

@mezotv
Copy link

mezotv commented Mar 1, 2024

Discord just reverted this after the commit :kekw:

@mezotv
Copy link

mezotv commented Mar 1, 2024

Purge would then require the MANAGE_GUILD and KICK_MEMBERS permissions. Might be good to include both ig?

@shiftinv shiftinv added t: documentation Improvements or additions to documentation/examples s: waiting for api/docs Issue/PR is waiting for API support/documentation skip news labels Mar 1, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Mar 1, 2024
@mezotv
Copy link

mezotv commented Mar 12, 2024

@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Mar 19, 2024
@shiftinv
Copy link
Member

this one should be ready to go now, I believe?

@mezotv
Copy link

mezotv commented Mar 19, 2024

this one should be ready to go now, I believe?

Yep, should be ready to be merged now!

@vcokltfre vcokltfre marked this pull request as ready for review March 19, 2024 18:20
@Victorsitou
Copy link
Member

Perhaps it would also be a good idea to update the documentation of Guild.estimate_pruned_members and add the required permissions to use it

@shiftinv
Copy link
Member

Perhaps it would also be a good idea to update the documentation of Guild.estimate_pruned_members and add the required permissions to use it

It links to prune_members already, so this should be fine to leave as-is for now

@shiftinv shiftinv enabled auto-merge (squash) March 22, 2024 14:46
@shiftinv shiftinv merged commit 94d40f9 into master Mar 22, 2024
27 checks passed
@shiftinv shiftinv deleted the vcokltfre/docs/update-prune-permissions branch March 22, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: documentation Improvements or additions to documentation/examples
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants