Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(message): implement message forwarding #1188

Merged
merged 38 commits into from
Dec 11, 2024
Merged

feat(message): implement message forwarding #1188

merged 38 commits into from
Dec 11, 2024

Conversation

Snipy7374
Copy link
Collaborator

Summary

This feature is still untested as message forwarding is not available yet

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 changed the title Feat/forward feat(message): implement message forwarding Apr 27, 2024
@shiftinv shiftinv added t: enhancement New feature t: api support Support of Discord API features s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Apr 28, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Apr 28, 2024
@shiftinv shiftinv self-requested a review April 28, 2024 10:48
@Snipy7374
Copy link
Collaborator Author

Snipy7374 commented Apr 29, 2024 •
edited
Loading

I need to add guild_id as parameter to MessageReference.from_message as well in Message.to_reference so a user can choose where to forward a message, writing this here to remember it later. solved

@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label Aug 9, 2024
shiftinv
shiftinv requested changes Nov 14, 2024
View reviewed changes
disnake/abc.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/types/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/types/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
shiftinv
shiftinv reviewed Nov 16, 2024
View reviewed changes
disnake/abc.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Show resolved Hide resolved
docs/api/messages.rst Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
Snipy7374 and others added 7 commits November 16, 2024 18:05
@Snipy7374 @shiftinv
Update disnake/abc.py
8db23bf 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @shiftinv
Update disnake/message.py
c9181d0 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @shiftinv
Update disnake/message.py
fb8a4b7 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @shiftinv
Update docs/api/messages.rst
32f682b 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @shiftinv
Update disnake/message.py
f93efc8 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374 @shiftinv
Update disnake/message.py
bbbc5c7 
Co-authored-by: shiftinv <[email protected]>
Signed-off-by: Snipy7374 <[email protected]>
@Snipy7374
feat: apply suggested changes
9e54d14
@Snipy7374 Snipy7374 requested a review from shiftinv November 18, 2024 10:32
@shiftinv shiftinv mentioned this pull request Nov 19, 2024
Merged
8 tasks
shiftinv
shiftinv reviewed Nov 21, 2024
View reviewed changes
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
disnake/message.py Outdated Show resolved Hide resolved
@Snipy7374 Snipy7374 requested a review from shiftinv November 22, 2024 22:41
@Snipy7374
Copy link
Collaborator Author

Snipy7374 commented Nov 22, 2024 •
edited
Loading

Since it's in the scope of this PR (implementing message forwarding) I'm gonna add the new message flag

discord/discord-api-docs#7253

shiftinv
shiftinv reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one final documentation pass

docs/api/messages.rst Show resolved Hide resolved
docs/api/messages.rst Outdated Show resolved Hide resolved
shiftinv
shiftinv approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for working on this!

@shiftinv shiftinv merged commit 08b2bea into DisnakeDev:master Dec 11, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.10
Development

Successfully merging this pull request may close these issues.

implement message forwards feature
2 participants
@Snipy7374 @shiftinv