CADENZA-33417 [Embedding FA] Parameters to control table contents #10
Conversation
anistor
changed the title
anistor
force-pushed
the
slb/an/CADENZA-33417
branch
from
2c7eb37 to
592650d
Compare
|
I've addressed all comments added up to now. Thanks @jkissel ! |
src/cadenza.js
Outdated
| @@ -608,6 +616,26 @@ function validGeometryType(/** @type string */ value) { | |||
| ].includes(value); | |||
| } | |||
|
|
|||
| /** @typedef {'columns' | 'values' | 'totals'} TablePart - A part of a table to export. */ | |||
|
|
|||
| const TablePart = /** @type {Record<string, TablePart>} */ { | |||
There was a problem hiding this comment.
This mapping is unused in Cadenza JS, an array of the values would be sufficient.
There was a problem hiding this comment.
Should the client code be able to use those constants? (if our code does not use them directly)
I can remove them just making sure it is really intended to obliterate them.
I see for geometries we do not have defined individual constants just an array of the possible values (as you suggest here) but for MediaTypes we have constants (which we also use in our code directly). Which of the 2 approaches is best?
There was a problem hiding this comment.
The geometry types are used inside of the lib. If clients should be able to use this mapping, it needs to be exported and should be marked as @readonly and really made readonly using Object.freeze().
anistor
force-pushed
the
slb/an/CADENZA-33417
branch
from
592650d to
5ea8c57
Compare
* add optional 'parts' parameter to #fetchData and #downloadData
anistor
force-pushed
the
slb/an/CADENZA-33417
branch
from
5ea8c57 to
32cd8ba
Compare
|
|
||
| const tableData = await response.json(); | ||
| ... | ||
| ``` |
src/cadenza.js
Outdated
| @@ -608,6 +616,26 @@ function validGeometryType(/** @type string */ value) { | |||
| ].includes(value); | |||
| } | |||
|
|
|||
| /** @typedef {'columns' | 'values' | 'totals'} TablePart - A part of a table to export. */ | |||
|
|
|||
| const TablePart = /** @type {Record<string, TablePart>} */ { | |||
There was a problem hiding this comment.
The geometry types are used inside of the lib. If clients should be able to use this mapping, it needs to be exported and should be marked as @readonly and really made readonly using Object.freeze().
|
Thanks @jkissel ! |
Add optional 'parts' parameter to #fetchData and #downloadData
https://jira.disy.net/browse/CADENZA-33417