Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: i18n displays real lang name #995

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from
Open

feat: i18n displays real lang name #995

wants to merge 3 commits into from
+39 −36

Conversation

190km
Copy link
Contributor

@190km 190km commented Dec 25, 2024 •
edited
Loading

Before

{602B3A11-1661-435C-86CD-70CB8ED07BD8}

After

image

@190km 190km requested a review from Siumauricio as a code owner December 25, 2024 23:15
@190km 190km marked this pull request as draft December 25, 2024 23:25
@190km 190km changed the title feat: refactored i18n to display real lang name refactor: refactored i18n to display real lang name Dec 26, 2024
@190km 190km marked this pull request as ready for review December 26, 2024 00:37
@Siumauricio
Copy link
Contributor

What's the main change here? I belive what we have is more cleaner than this implementation 🤔

@190km
Copy link
Contributor Author

190km commented Dec 27, 2024

What's the main change here? I belive what we have is more cleaner than this implementation 🤔

it's not really a refactor, it's just to display the name of the language as it is in the original country

@190km 190km changed the title refactor: refactored i18n to display real lang name feat: i18n displays real lang name Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siumauricio Siumauricio Awaiting requested review from Siumauricio Siumauricio is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@190km @Siumauricio