Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PiP support #47

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Add PiP support #47

merged 5 commits into from
Feb 9, 2024

Conversation

aravind-raveendran
Copy link
Contributor

@aravind-raveendran aravind-raveendran commented Jan 8, 2024

Description:

  1. Consume 1.7.0 SDK drop to consume new Video Renderer Views(MCSampleBufferVideoUIView) that support PiP
  2. Add app side PiP implementation

Pending:

  1. The new PiP Views does not provide a way to determine the VideoSize, hence the app implementation still uses the McIOSRenderer object to calculate the video tile size. This issue is highlighted to the SDK team

RameshDPrasad
RameshDPrasad previously approved these changes Feb 5, 2024
RameshDPrasad
RameshDPrasad previously approved these changes Feb 5, 2024
@aravind-raveendran aravind-raveendran merged commit 8bc9d44 into main Feb 9, 2024
2 checks passed
@aravind-raveendran aravind-raveendran deleted the feature/add-pip-support branch February 9, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants