Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] stop using updateConfiguration #315

Closed

Conversation

rei-m
Copy link
Contributor

@rei-m rei-m commented Feb 12, 2017

Issue

Overview (Required)

  • SetUp Locale on attachBaseContext. And Pass that to CalligraphyContextWrapper.
  • Remove SetUp Context from LocaleUtil.

Links

Screenshot

Before After

@konifar
Copy link
Contributor

konifar commented Feb 12, 2017

👀

@konifar
Copy link
Contributor

konifar commented Feb 12, 2017

Thanks! 👍
I have a question 🙋

SetUp Locale on attachBaseContext. And Pass that to CalligraphyContextWrapper.

The locale is initialized in BaseActivity on this PR.
Is it applied to non-activity class such as Notification?

@rei-m
Copy link
Contributor Author

rei-m commented Feb 12, 2017

The locale is initialized in BaseActivity on this PR.
Is it applied to non-activity class such as Notification?

No... This Setting is applied only activities. Locale of Notification is SystemLocale.
I searched to apply configuration that created by context.createConfigurationContext, and found this solution only.

@shiren-wanderer
Copy link

As @rei-m mentioned, this is only for activities but not non-activity stuff.
The main issue here is that createConfigurationContext() just returns context instead of directly updating it. Thus, MainApplication's context only can have the latest locale after app restart.

@konifar
Copy link
Contributor

konifar commented Feb 12, 2017

@rei-m Sorry, I'm not sure this is correct fix or not.
Please let me investigate more and wait to merge 🙇

@rei-m
Copy link
Contributor Author

rei-m commented Feb 12, 2017

@shiren-wanderer Thanks 🙇 I'll try to setup at Application's attachBaseContext.

@konifar OK. I continue to investigation too.

@konifar konifar changed the title stop using updateConfiguration [WIP] stop using updateConfiguration Feb 13, 2017
@konifar
Copy link
Contributor

konifar commented Feb 23, 2017

Sorry for too late review 🙇 🙇 🙇
In my investigation, latest Android doesn't want to allow changing locale from app 🤔
So I want to move this locale change option to debug menu.
If you agree, I'll create another issue.
What do you think?

@rei-m
Copy link
Contributor Author

rei-m commented Feb 23, 2017

@konifar Ok!! I agree👌 then please close this PR and create another issue 🙇

@rei-m rei-m closed this Mar 7, 2017
@rei-m rei-m deleted the 280_stop_using_updateConfiguration branch March 7, 2017 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants