[WIP]Add navigational transition #407

takahirom · 2017-03-07T06:21:59Z

Overview (Required)

This pull request is not require on DroidKaigi 2017/3/9
This pull request is just suggestion.
Add navigational transition
Currently require code clean up
Currently not compatible for pre lollipop
Currently not add license
Currently not stable(Multiple time starting activity occur clash )

FATAL EXCEP

TION: main
Process: io.github.droidkaigi.confsched2017.develop.debug, PID: 14175
java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.ViewGroup.transformMatrixToGlobal(android.graphics.Matrix)' on a null object reference
    at android.view.GhostView.calculateMatrix(GhostView.java:89)
    at android.app.ActivityTransitionCoordinator$GhostViewListeners.onPreDraw(ActivityTransitionCoordinator.java:1000)
    at android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:944)
    at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2205)
    at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1254)
    at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:6337)
    at android.view.Choreographer$CallbackRecord.run(Choreographer.java:874)
    at android.view.Choreographer.doCallbacks(Choreographer.java:686)
    at android.view.Choreographer.doFrame(Choreographer.java:621)
    at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:860)
    at android.os.Handler.handleCallback(Handler.java:751)
    at android.os.Handler.dispatchMessage(Handler.java:95)
    at android.os.Looper.loop(Looper.java:154)
    at android.app.ActivityThread.main(ActivityThread.java:6119)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

If I resolve problems ,can you merge this?

Links

Screenshot

konifar · 2017-03-07T06:33:26Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/FadeOutTransition.java

+    }
+
+    public FadeOutTransition(Context context, AttributeSet attrs) {
+        super(context, attrs);


[Android Lint] _{reported by reviewdog 🐶}
Error: Call requires API level 21 (current min is 19): new android.transition.Transition [NewApi]

konifar · 2017-03-07T06:33:26Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/LiftOff.java

+    @Override
+    public Animator createAnimator(ViewGroup sceneRoot, TransitionValues startValues,
+                                   TransitionValues endValues) {
+        return ObjectAnimator.ofFloat(endValues.view, View.TRANSLATION_Z,


[Android Lint] _{reported by reviewdog 🐶}
Error: Field requires API level 21 (current min is 16): android.view.View#TRANSLATION_Z [NewApi]

konifar · 2017-03-07T06:33:26Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/LiftOff.java

+ * (https://www.google.com/design/spec/patterns/navigational-transitions.html#navigational-transitions-parent-to-child)
+ * when combined with a {@link android.transition.ChangeBounds} on a shared element.
+ */
+public class LiftOff extends Transition {


[Android Lint] _{reported by reviewdog 🐶}
Error: Class requires API level 19 (current min is 16): android.transition.Transition [NewApi]

konifar · 2017-03-07T06:33:26Z

app/src/main/res/layout/activity_session_detail.xml

@@ -8,6 +8,8 @@
            android:id="@+id/content_view"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
+            android:background="@color/white"
+            android:transitionName="@string/session_detail"


[Android Lint] _{reported by reviewdog 🐶}
Warning: Attribute transitionName is only used in API level 21 and higher (current min is 16) [UnusedAttribute]

konifar · 2017-03-07T06:33:26Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/LiftOff.java

+    private final float finalElevation;
+
+    public LiftOff(Context context, AttributeSet attrs) {
+        super(context, attrs);


[Android Lint] _{reported by reviewdog 🐶}
Error: Call requires API level 21 (current min is 16): new android.transition.Transition [NewApi]

konifar · 2017-03-07T06:33:26Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/FadeInTransition.java

+    }
+
+    public FadeInTransition(Context context, AttributeSet attrs) {
+        super(context, attrs);


[Android Lint] _{reported by reviewdog 🐶}
Error: Call requires API level 21 (current min is 19): new android.transition.Transition [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/LiftOff.java

+
+    @Override
+    public void captureEndValues(TransitionValues transitionValues) {
+        transitionValues.values.put(PROPNAME_ELEVATION, finalElevation);


[Android Lint] _{reported by reviewdog 🐶}
Error: Field requires API level 19 (current min is 16): android.transition.TransitionValues#values [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/motion/GravityArcMotion.java

+    @Override
+    public void setMaximumAngle(float angleInDegrees) {
+        mMaximumAngle = angleInDegrees;
+        mMaximumTangent = toTangent(angleInDegrees);


[Android Lint] _{reported by reviewdog 🐶}
Error: Call requires API level 21 (current min is 16): android.transition.ArcMotion#toTangent [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/activity/SessionDetailActivity.java

@@ -48,6 +54,37 @@ protected void onCreate(Bundle savedInstanceState) {
            }
        }
        replaceFragment(SessionDetailFragmentCreator.newBuilder(sessionId).build(), R.id.content_view);
+
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
+            getWindow().getSharedElementEnterTransition().addListener(new Transition.TransitionListener() {


[Android Lint] _{reported by reviewdog 🐶}
Error: Class requires API level 19 (current min is 16): android.transition.Transition.TransitionListener [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/LiftOff.java

+    @Override
+    public Animator createAnimator(ViewGroup sceneRoot, TransitionValues startValues,
+                                   TransitionValues endValues) {
+        return ObjectAnimator.ofFloat(endValues.view, View.TRANSLATION_Z,


[Android Lint] _{reported by reviewdog 🐶}
Error: Field requires API level 19 (current min is 16): android.transition.TransitionValues#view [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/motion/GravityArcMotion.java

+    }
+
+    public GravityArcMotion(Context context, AttributeSet attrs) {
+        super(context, attrs);


[Android Lint] _{reported by reviewdog 🐶}
Error: Call requires API level 21 (current min is 16): new android.transition.ArcMotion [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/transition/LiftOff.java

+
+    @Override
+    public void captureStartValues(TransitionValues transitionValues) {
+        transitionValues.values.put(PROPNAME_ELEVATION, initialElevation);


[Android Lint] _{reported by reviewdog 🐶}
Error: Field requires API level 19 (current min is 16): android.transition.TransitionValues#values [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/motion/GravityArcMotion.java

+    @Override
+    public void setMinimumHorizontalAngle(float angleInDegrees) {
+        mMinimumHorizontalAngle = angleInDegrees;
+        mMinimumHorizontalTangent = toTangent(angleInDegrees);


[Android Lint] _{reported by reviewdog 🐶}
Error: Call requires API level 21 (current min is 16): android.transition.ArcMotion#toTangent [NewApi]

konifar · 2017-03-07T06:33:27Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/motion/GravityArcMotion.java

+ * <p>
+ * See https://www.google.com/design/spec/motion/movement.html#movement-movement-within-screen-bounds
+ */
+public class GravityArcMotion extends ArcMotion {


[Android Lint] _{reported by reviewdog 🐶}
Error: Class requires API level 21 (current min is 16): android.transition.ArcMotion [NewApi]

konifar · 2017-03-07T06:33:28Z

app/src/main/java/io/github/droidkaigi/confsched2017/view/motion/GravityArcMotion.java

+    @Override
+    public void setMinimumVerticalAngle(float angleInDegrees) {
+        mMinimumVerticalAngle = angleInDegrees;
+        mMinimumVerticalTangent = toTangent(angleInDegrees);


[Android Lint] _{reported by reviewdog 🐶}
Error: Call requires API level 21 (current min is 16): android.transition.ArcMotion#toTangent [NewApi]

konifar · 2017-03-07T06:52:23Z

Cool 🆒
This is related with your session, right? 😃
I'm for your suggestion.

takahirom · 2017-03-07T07:06:38Z

Thanks!
That's right.
I will talk about this pull request contents.

Add navigational transition

6630570

KeithYokoma added the in progress label Mar 7, 2017

konifar reviewed Mar 7, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP]Add navigational transition #407

[WIP]Add navigational transition #407

takahirom commented Mar 7, 2017 •

edited

Loading

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar Mar 7, 2017

konifar commented Mar 7, 2017

takahirom commented Mar 7, 2017

[WIP]Add navigational transition #407

Are you sure you want to change the base?

[WIP]Add navigational transition #407

Conversation

takahirom commented Mar 7, 2017 • edited Loading

Overview (Required)

Links

Screenshot

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

konifar commented Mar 7, 2017

takahirom commented Mar 7, 2017

takahirom commented Mar 7, 2017 •

edited

Loading