Added: BLE Serial Port Profile #103
Conversation
|
The |
Update
|
Refactor : Formated Headers Refactor : Formated esp32 control module Refactor : Formated esp32 control module Refactor: Cleaned up some more files
UpdateThis PR is done for review, the |
|
Oops, Looks like I need to change the SDK Configuration files. |
Got it workingNeed to do something about the latency, i suspect queues are making it slow |
|
https://github.com/Witty-Wizard/ESP32-DroneBridge/blob/f982386756cade35aebef7eec1fbe5ea8d9b8bd2/main/db_ble.h#L43 |
|
@seeul8er, please test this on your end as well. I am also looking at the possibility of flashing the flight controller over Bluetooth, for that I have created 2 new characteristics for reading and writing commands but this would require changes in the configurator as well. I will talk with the Betalight developers as they are also working on Bluetooth flashing. |
* Added: BLE Serial Port Profile * Added: bluetooth control module (as much as i understood) * Added: Sending data from BLE callback to uart * Fixed: Error on Wi-Fi Connection * Added: task fro getting data from queue * Added: Global queues for BLE task (Need to do some testing, and then refractor the code) * Refactor: Cleaned up code with comments and documentation Refactor : Formated Headers Refactor : Formated esp32 control module Refactor : Formated esp32 control module Refactor: Cleaned up some more files * Refactor: Cleaned esp now files * Removed: .vscode directory (When did i push that lol) * Added: NimBLE Config to sdkconfig files * Refactor: Cleaned up db_serial files * Fixed: BLE Task not yielding to scheduler * Added: Notify and read characterisitc for betaflight * Added: Global Queues (need to shift esp now queues) * Added: Command Characteristics (Might be useful later for flashing purposes) * Added: Pushing data pointer to queue to save transfer time
|
@seeul8er, how to update the |
|
I will check today and tomorrow 👍 |
|
@seeul8er, are u planning to merge https://github.com/DroneBridge/ESP32/tree/v2.0dev into main, if yes then please do so that I can rebase my changes on top of it, this will be much easier and quicker |
|
Hi, yes I do. Sorry for the delay I had a lot of other things to do in the last days. I hope I can integrate it in the coming two days. |
|
@Witty-Wizard merged into master |
great, I will create a new PR, that would be easier than resolving the conflicts. |
|
@Witty-Wizard For the new request it would be nice if you could focus it on the BLE addition. In the previous one there were a lot of editorial changes and formatting changes. This makes it hard for me to follow and I am not sure I want half the project reformatted. Even when some of these made good sense 😊 |
|
@seeul8er, Yes I had the same thoughts, I still need to have a global queue or i can implement a queue specifically for In a later PR I would still suggest some format changes, as the code readability is not that good. I can see that as the project progressed some changes could have been handled in a better and more readable way. NVM for now I'll just make changes for the |
|
@Witty-Wizard For now we can do separate Queues. We can check in a later step to fuse them |
Great, that's what I have done |
@seeul8er, I have created this Pull Request for review purposes, this is still a work in progress, as stated in #97, I managed to get data from
Betaflight Configurator. I will do full testing before submitting the final PR