-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 16 #61
Feature/issue 16 #61
Conversation
this looks awesome so far, thanks for all of the effort on this! the next step would be to make sure you can open a file, and include a unit test showing a round trip test of some operation involving a keypair like signing and verifying a message, or encrypting and decrypting, existing tests for these already exist in |
@drcapybara |
Perfect! Everything looks great! Thanks so much for this. The last thing to do on this to merge this in is to do the exact same thing for the
Then this is ready to merge in! You're doing great work so far! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, you can merge if you would like! This is a great foundation to introduce the rest of the commands into the library
This pull request addresses the following issues:
save_to_file
functionality for KeyPair.To execute the command, use the following syntax:
capycrypt new_keypair "pw" "owner" -b 256 --output "output.json"
Note: The curve input has been excluded for now as it is not part of the KeyPair::new() method.