Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update finagle-thrift, scrooge-core, ... to 22.12.0 #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dwolla-oss-scala-steward[bot]
Copy link
Contributor

@dwolla-oss-scala-steward dwolla-oss-scala-steward bot commented May 24, 2023

About this PR

📦 Updates

from 22.7.0 to 22.12.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (22.7.0).
You might want to review and update them manually.

.github/workflows/ci.yml
README.md
scalafix/README.md
scalafix/input/src_managed/main/scala/example/thrift/SimpleRequest.scala
scalafix/input/src_managed/main/scala/example/thrift/SimpleResponse.scala
scalafix/input/src_managed/main/scala/example/thrift/SimpleService$FinagleClient.scala
scalafix/input/src_managed/main/scala/example/thrift/SimpleService$FinagleService.scala
scalafix/input/src_managed/main/scala/example/thrift/SimpleService.scala
scalafix/output/src_managed/main/scala/example/thrift/SimpleRequest.scala
scalafix/output/src_managed/main/scala/example/thrift/SimpleResponse.scala
scalafix/output/src_managed/main/scala/example/thrift/SimpleService$FinagleClient.scala
scalafix/output/src_managed/main/scala/example/thrift/SimpleService$FinagleService.scala
scalafix/output/src_managed/main/scala/example/thrift/SimpleService.scala
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.twitter" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.twitter" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

@dwolla-oss-scala-steward dwolla-oss-scala-steward bot requested a review from a team as a code owner May 24, 2023 20:05
@bpholt
Copy link
Member

bpholt commented May 26, 2023

This is going to need some work to incorporate the changes made upstream into our code. When that's done, we should also remove all the "Revert commit" noise from the commit history before merging.

@bpholt
Copy link
Member

bpholt commented Jan 26, 2024

I think the build definition needs to be tweaked so that the "latest" artifact isn't checked for bincompat (because it will be empty) and the new ones aren't either, since they haven't been published in the past.

@dwolla-oss-scala-steward dwolla-oss-scala-steward bot force-pushed the update/finagle-thrift-22.12.0 branch from c028fd1 to 82bebba Compare January 27, 2024 00:03
@dwolla-oss-scala-steward dwolla-oss-scala-steward bot force-pushed the update/finagle-thrift-22.12.0 branch from 82bebba to 021feb0 Compare March 14, 2024 00:03
@bpholt bpholt force-pushed the update/finagle-thrift-22.12.0 branch 2 times, most recently from d53ba2c to c33ca2f Compare March 14, 2024 23:17
bpholt
bpholt previously approved these changes Mar 14, 2024
@bpholt bpholt force-pushed the update/finagle-thrift-22.12.0 branch from 501b35c to 0efe268 Compare March 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant